Skip to content

ENH: Wrap cast image filter for VectorImage#2073

Merged
thewtex merged 2 commits intoInsightSoftwareConsortium:masterfrom
Leengit:wrap_CastImageFilter
Nov 2, 2020
Merged

ENH: Wrap cast image filter for VectorImage#2073
thewtex merged 2 commits intoInsightSoftwareConsortium:masterfrom
Leengit:wrap_CastImageFilter

Conversation

@Leengit
Copy link
Copy Markdown
Contributor

@Leengit Leengit commented Oct 27, 2020

Building on code of @thewtex, this code is wrapping image casting to and from itk::VectorImage< ... > from several itk::Image< ... > types such as those based upon itk::Vector< ... > or itk::RGBPixel< ... > pixel types.

PR Checklist

  • Added test (or behavior not changed)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Submitting this as a draft pull request to trigger Github actions. It is not yet ready for review.

@dzenanz
Copy link
Copy Markdown
Member

dzenanz commented Oct 27, 2020

MacOS CI complains about:

git checkout b4914c3be66beba293099e7a04b358a441c8602b
fatal: reference is not a tree: b4914c3be66beba293099e7a04b358a441c8602b

Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Leengit !

Please try enabling additional pixel types in the wrapping configuration locally and build / test to ensure that we do not have duplicate types wrapping before merging..

@Leengit
Copy link
Copy Markdown
Contributor Author

Leengit commented Oct 29, 2020

This pull request addresses issue #1133.

I am running the following code and will mark this as a non-draft pull request if all is successful.

cmake -DCMAKE_BUILD_TYPE:STRING=Debug -DBUILD_TESTING:BOOL=ON \
    -DCMAKE_INSTALL_PREFIX:PATH=~/git/ITK-install -DITK_WRAP_PYTHON:BOOL=ON \
    -DITK_WRAP_complex_double:BOOL=ON -DITK_WRAP_complex_float:BOOL=ON \
    -DITK_WRAP_covariant_vector_double:BOOL=ON -DITK_WRAP_covariant_vector_float:BOOL=ON \
    -DITK_WRAP_double:BOOL=ON -DITK_WRAP_float:BOOL=ON \
    -DITK_WRAP_rgba_unsigned_char:BOOL=ON -DITK_WRAP_rgba_unsigned_short:BOOL=ON \
    -DITK_WRAP_rgb_unsigned_char:BOOL=ON -DITK_WRAP_rgb_unsigned_short:BOOL=ON \
    -DITK_WRAP_signed_char:BOOL=ON -DITK_WRAP_signed_long_long:BOOL=ON \
    -DITK_WRAP_signed_short:BOOL=ON -DITK_WRAP_unsigned_char:BOOL=ON \
    -DITK_WRAP_unsigned_long_long:BOOL=ON -DITK_WRAP_unsigned_short:BOOL=ON \
    -DITK_WRAP_vector_double:BOOL=ON -DITK_WRAP_vector_float:BOOL=ON \
    ~/git/ITK
cmake --build . --target install
ctest

@Leengit
Copy link
Copy Markdown
Contributor Author

Leengit commented Oct 31, 2020

This build did not produce any new warnings for template already defined so I am going to go ahead and mark this pull request as ready for review/submission. I have submitted Issue #2083 for the pre-existing template already defined warnings.

@Leengit Leengit marked this pull request as ready for review October 31, 2020 22:54
@thewtex thewtex merged commit 3aec776 into InsightSoftwareConsortium:master Nov 2, 2020
@Leengit Leengit deleted the wrap_CastImageFilter branch November 18, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants